Adding a link to the PR that introduced this feature for "owner" and "group".
#22526

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (76d897e) to head (bc29572).
Report is 448 commits behind head on master.

@@             Coverage Diff             @@
##           master   #29287       +/-   ##
===========================================
+ Coverage   60.48%   83.74%   +23.25%     
===========================================
  Files        1931      524     -1407     
  Lines       76236    37789    -38447     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31646    -14468     
+ Misses      28017     6143    -21874     
+ Partials     2105        0     -2105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar : I think I have corrected the formatting. Would be nice if you can start the workflows again.

CI running 🤞

@rusackas : Added missing newline to get ruff linter happy

@dpgaspar would love to get a new CI run...

Would love to get some feedback if this PR is considered for merging. Or if I can improve it in some way.

Updated branch with master to resolve merge conflict

Updated the "summary" of this PR with a better description and added "testing instructions"

Running CI again :)

Anything else I can do to get this approved/merged?

This looks awesome @marre - we would also greatly benefit from this. We'll be crossing our fingers for approval soon and we'll be willing to help if any additional work is needed

Done! Thanks for your contribution!

Thanks!

In what release will it be included in?

@supersetbot label 4.1

@marre, thank you! However, you mentioned that this would fix the 'Modified By' field issue, but the only field currently removing the list of users is 'Owner'.

Example for the 'Owner' field:

Example for the 'Modified By' field

Is there any configuration that I'm missing?

Hide all users

from sqlalchemy.sql import false

def user_filter(query):
    return query.filter(false())
        
EXTRA_RELATED_QUERY_FILTERS = {
       "user": user_filter,
       "changed_by": user_filter
 }              

@supersetbot unlabel 4.1

@sadpandajoe Would really love to have this in 4.1...

@bruno-santos-6 What version of superset are you testing with?

Just pulled latest from superset/superset (master branch@40520c54d40f887453827ef36a9f5924119ada62)

Without EXTRA_RELATED_QUERY_FILTERS

Without EXTRA_RELATED_QUERY_FILTERS configured:

Owner:

Modified-by:

With EXTRA_RELATED_QUERY_FILTERS

Added this to my superset_config.py:

def user_filter(query):
    from sqlalchemy.sql import false
    return query.filter(false())

EXTRA_RELATED_QUERY_FILTERS = {
    "user": user_filter,
}

Started with:

export SUPERSET_CONFIG_PATH=./superset_config.py
superset run -p 8088 --with-threads --reload --debugger --debug

Owner after:

Modified-by after:

Noticed that I had a typo in the first sentence of the description. I wrote "modified-by" where I intended "owner" and vice-versa. Corrected in description.

@marre You are right, I deployed Superset using Helm on Kubernetes, and the latest version of Superset available in the official chart is 4.0.1. I will try to apply version 4.0.2

You have to either grab it directly from github from master branch or wait for a release where this PR will be included in. I hope it will be in 4.1.0 as it was once tagged with 4.1, but that tag has been removed. So I really don't know when this will be included in a release.