-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add user filtering to changed_by. Fixes #27986 #29287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a link to the PR that introduced this feature for "owner" and "group". |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29287 +/- ##
===========================================
+ Coverage 60.48% 83.74% +23.25%
===========================================
Files 1931 524 -1407
Lines 76236 37789 -38447
Branches 8568 0 -8568
===========================================
- Hits 46114 31646 -14468
+ Misses 28017 6143 -21874
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@dpgaspar : I think I have corrected the formatting. Would be nice if you can start the workflows again. |
CI running 🤞 |
Would love to get some feedback if this PR is considered for merging. Or if I can improve it in some way. |
Updated branch with master to resolve merge conflict |
Updated the "summary" of this PR with a better description and added "testing instructions" |
Running CI again :) |
Anything else I can do to get this approved/merged? |
This looks awesome @marre - we would also greatly benefit from this. We'll be crossing our fingers for approval soon and we'll be willing to help if any additional work is needed |
Done! Thanks for your contribution! |
Thanks! In what release will it be included in? |
@supersetbot label 4.1 |
Co-authored-by: Markus Eriksson <[email protected]> (cherry picked from commit 922128f)
@marre, thank you! However, you mentioned that this would fix the 'Modified By' field issue, but the only field currently removing the list of users is 'Owner'. Example for the 'Owner' field: Example for the 'Modified By' field Is there any configuration that I'm missing? Hide all users
|
@supersetbot unlabel 4.1 |
@sadpandajoe Would really love to have this in 4.1... @bruno-santos-6 What version of superset are you testing with? Just pulled latest from superset/superset (master branch@40520c54d40f887453827ef36a9f5924119ada62) Without EXTRA_RELATED_QUERY_FILTERSWithout EXTRA_RELATED_QUERY_FILTERS configured: With EXTRA_RELATED_QUERY_FILTERSAdded this to my superset_config.py:
Started with:
|
Noticed that I had a typo in the first sentence of the description. I wrote "modified-by" where I intended "owner" and vice-versa. Corrected in description. |
@marre You are right, I deployed Superset using Helm on Kubernetes, and the latest version of Superset available in the official chart is 4.0.1. I will try to apply version 4.0.2 |
You have to either grab it directly from github from master branch or wait for a release where this PR will be included in. I hope it will be in 4.1.0 as it was once tagged with 4.1, but that tag has been removed. So I really don't know when this will be included in a release. |
Co-authored-by: Markus Eriksson <[email protected]> (cherry picked from commit 922128f)
SUMMARY
The EXTRA_RELATED_QUERY_FILTERS option only affected the "owner" field, this PR changes it to also apply to the "modified by" field.
This option is currently used in a superset installation where a superset user should not be able to list other superset user names. Without this PR a superset user can list the names of other users in the "modified by" field.
Fixes #27986
Documentation of the
EXTRA_RELATED_QUERY_FILTERS
:Example
superset_config.py
with EXTRA_RELATED_QUERY_FILTERS configured to hide all users:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION